-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keycloak_quarkus: use absolute path for certificate files #39
keycloak_quarkus: use absolute path for certificate files #39
Conversation
I am ok with the change, but you'll need to update meta/argument_specs, defaults/main.yml and README as well |
063eb5b
to
41caa49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change will break existing configurations, unless they are using the default value. Not sure how to warn users about this |
I was thinking at that; if it is breaking, I'll switch labels on the PR from minor_change to breaking_change; the generated changelog will contain a link to this page: so please edit your first comment with a few lines of description and porting guide |
I'm not sure on why CI is failing now |
Could be docker running out of ports; lets try again and if it fails I'll debug molecule later |
Found the issue here: |
LGTM (again) thanks for contributing |
If you want to use a certificate for both Keycloak and Nginx, the cert files are quite unlikely to be under
keycloak.home
Even in case you want to keep the under Keycloak path, you can always define the variable:
This change will break your previous configuration (unless you use the default values).
To fix your config for the new changes, you will have use full paths for the 2 variables mentioned above. For example: