Make keycloak_admin_password a default with assert (was: role variable)
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidograzioli
force-pushed
the
keycloak_admin_password_var
branch
from
89d4a99 to
85b0a25
Compare
rpelisse
reviewed
Mar 25, 2022
| @@ -8,3 +8,4 @@ | |||
| ansible.builtin.assert: | |||
| that: | |||
| - ansible_facts.services["keycloak.service"]["state"] == "running" | |||
| - ansible_facts.services["keycloak.service"]["status"] == "enabled" | |||
There was a problem hiding this comment.
We need to add that in the validation role in the other collection!!! (also we need to turn this verify into a validation role for keycloak)
rpelisse
reviewed
Mar 25, 2022
| @@ -6,7 +6,7 @@ | |||
| ansible.builtin.include_role: | |||
| name: middleware_automation.keycloak.keycloak_realm | |||
| vars: | |||
| keycloak_admin_password: "changeme" | |||
| keycloak_admin_password: "remembertochangeme" | |||
rpelisse
approved these changes
Mar 25, 2022
guidograzioli
added
the
minor_changes
guidograzioli
changed the title
guidograzioli
changed the title
keycloak_admin_password a default with assert (was: role variable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #22