Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for policy files #225

Merged

Conversation

hwo-wd
Copy link
Collaborator

@hwo-wd hwo-wd commented May 14, 2024

New parameters for the installation of policy files:

Variable Description Default
keycloak_quarkus_policies List of policy definitions; see below []

Policy definition:

keycloak_quarkus_policies:
  - name: xato-net-10-million-passwords.txt    # required, resulting file name
    url: https://github.com/path/to/policy.txt # required, url for download
    type: password-blacklists                  # optional, defaults to `password-blacklists`;
                                               # supported values: [`password-blacklists`]

Fix #224

@hwo-wd hwo-wd requested a review from guidograzioli May 14, 2024 06:38
Copy link
Member

@guidograzioli guidograzioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset good, but missing the argument spec (https://github.com/ansible-middleware/keycloak/blob/main/roles/keycloak_quarkus/meta/argument_specs.yml) definition for the two new parameters. For myself, need to verify why the linter rule didn't report same

@guidograzioli guidograzioli added the minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix label May 14, 2024
@hwo-wd hwo-wd requested a review from guidograzioli May 14, 2024 06:59
@guidograzioli guidograzioli merged commit 1b69191 into ansible-middleware:main May 14, 2024
20 checks passed
@guidograzioli guidograzioli changed the title #224: keycloak_quarkus: Add support for policy files Add support for policy files May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keycloak_quarkus: Add support for policy files (e.g. password blacklists)
2 participants