-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for more http-related configs #115
Add support for more http-related configs #115
Conversation
17d3950
to
fe43f2a
Compare
I am merging the proxied deploy molecule test (disabled in CI); can you please rebase on top of HEAD, and enable it? |
74b2884
to
82b4f61
Compare
it seems not yet merged, will wait for it. FYI I've used these changes in my downstream PR and solved the issues I was facing |
You right, I've been stolen away from this PR too long. I have merged the molecule test (disable), can you please rebase, and commit a change here to enable it? |
* keycloak_quarkus_http_relative_path var now populate http-relative-path config [breaking change] * http-relative-path defaults to / [breaking change] * enable configuration of hostname-url and hostname-admin-url
82b4f61
to
880d70f
Compare
|
It also fails because the molecule tests sets: keycloak_quarkus_http_relative_path: / this turns into 3 slashes in the health endpoint in vars: health_url: "http://{{ keycloak_quarkus_host }}:{{ keycloak_quarkus_http_port }}/{{ keycloak_quarkus_http_relative_path }}{{ '/' if keycloak_quarkus_http_relative_path else '' }}realms/master/.well-known/openid-configuration" which confuses keycloak (it returns 404 resource not found). I'll let you decide if you prefer to have keycloak_quarkus_http_relative_path default to '/' (and fix the health url concatenation), or to keep empty string and only fix the health_url Otherwise, the changeset LGTM, and we can merge :) |
I preferred to switch to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix #114