-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run service as keycloak_service_user
#106
Conversation
22531fb
to
5bb036d
Compare
Signed-off-by: Massimo Schiavon <[email protected]>
Hello thanks for the PR; this is a much needed change, but it will create many side-effect on existing deployments (systemd not finding the pidfile for the running instance, files owned by root around not readable by the process, and so on). So for backwards compatibility, and to lower the PR level to major_change from breaking_change, can you please:
The above for the keycloak role only, while for keycloak_quarkus it is good as it is now |
add keycloak_service_runas feature flag fix previous installs permissions
LGTM; thank you very much for this contribution |
The actual implementation always runs the service as root user.
This PR uses the existing variables
keycloak_service_user
andkeycloak_service_group
to set the user and group of the startup script and so of the actual java process.I have also changed the default
keycloak_service_pidfile
value allowing to set the correct permissions on the folder containing the pidfile