The JWS installation option should allow you to exclude natives

[rpelisse]

Fixed #73 (and reduce code duplication)

[rpelisse]

@guidograzioli Can you review and approve?
@csutherl can you test to be sure that native is no longer an obligation?

[guidograzioli]

I think this PR contains many same commits as #89? Can you check?

[rpelisse]

@guidograzioli yes, it's designed to be merge after PR89.

[guidograzioli]

LGTM!

[csutherl]

@rpelisse I cloned the PR branch and tested it a bit, and found that there's one place you didn't add a tomcat_native check which was causing the native zipfile to still be required. Adding a check for tomcat_native == True to the when block in roles/jws/tasks/install/zipfiles.yml#L16 makes it work as expected.

I did notice another thing that we may want to address. If you run the script with the default tomcat_native: False and then run it again after setting tomcat_native: True it unpacks the zip as expected, but doesn't notify a restart of the Tomcat service. I had to manually restart the process for tomcat_native to be picked up. If we think this behavior is ok, we should probably document that a restart is required (after someone checks to make sure it's not an env problem).

[rpelisse]

@csutherl you are a god send! Thank you for spotting all of that. I think I've fixed everything and this PR should be good to go. However, if you can review (and /or test it) one last time, that certainly can't hurt :)

[csutherl]

@rpelisse I have a particular set of skills (spotting typos) 😆 My day is kind of full today, but I should be able to give it one more go this afternoon and provide some feedback. Thanks for being so quick to respond!

[csutherl]

I just tested the latest commit and it still doesn't work unless you add the tomcat_native check to roles/jws/tasks/install/zipfiles.yml so that the zipfiles list doesn't require the libtcnative.so. Without that check in place, you see the following failure when you run the playbook (having jws_version and tomcat_install_method defined):

TASK [middleware_automation.jws.jws : Install Jboss Web Server and required binaries from local zipfiles (install method: rhn_zipfiles] **************************************************************************************************************************************************************************************
changed: [localhost] => (item={'src': 'jws-5.6.0-application-server.zip', 'creates': '/opt/jws-5.6/tomcat/bin'})
failed: [localhost] (item={'src': 'jws-5.6.0-application-server-RHEL35-x86_64.zip', 'creates': '/opt/jws-5.6/tomcat/lib/libtcnative-1.so'}) => {"ansible_loop_var": "item", "changed": false, "item": {"creates": "/opt/jws-5.6/tomcat/lib/libtcnative-1.so", "src": "jws-5.6.0-application-server-RHEL35-x86_64.zip"}, "msg": "Source '/opt/jws-5.6.0-application-server-RHEL35-x86_64.zip' does not exist"}

[csutherl]

The opening braces are still missing :(

[rpelisse]

Darn! This was the very first thing I fixed up! It must have been squashed when I rebase :(

[rpelisse]

@csutherl OK, confirmed... Rebasing has removed all my changes... I guess "Don't rebase without testing". I'm going to update the PR. Sorry for that :(

[rpelisse]

@csutherl OK, added back the change, tested locally. But if you have the time to review again, that'll be awesome.

[csutherl]

LGTM! I appreciate you adding the restart notification, that works well too.

[rpelisse]

@csutherl Cool! No problem, it was a good idea to add notify :) Then I'll merge this right away :)