Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 5.7 release to rhn_ids #205

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Add 5.7 release to rhn_ids #205

merged 1 commit into from
Nov 16, 2022

Conversation

rpelisse
Copy link
Contributor

@csutherl please review and approve!

csutherl
csutherl reviewed Nov 11, 2022
View reviewed changes
Copy link
Collaborator

@csutherl csutherl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While checking the softwareId numbers for the zips I noticed that we're only recording the ID of the RHEL 8 zips. At least we are consistent between 5.6 and 5.7 (I didn't check others). Is that intentional @rpelisse ?

@rpelisse rpelisse self-assigned this Nov 14, 2022
@rpelisse rpelisse added the minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix label Nov 14, 2022
rpelisse
rpelisse commented Nov 16, 2022
View reviewed changes
Copy link
Contributor Author

@rpelisse rpelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rpelisse rpelisse merged commit 59362a8 into main Nov 16, 2022
@csutherl
Copy link
Collaborator

Closing the loop on #205 (review), yes it was intentional :)

@rpelisse rpelisse deleted the rhn_ids_57 branch February 20, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csutherl csutherl csutherl left review comments

@guidograzioli guidograzioli Awaiting requested review from guidograzioli

Assignees

@rpelisse rpelisse

Labels
minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpelisse @csutherl