Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sqlserver to infinispan jdbc configurations #25

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Add sqlserver to infinispan jdbc configurations #25

merged 4 commits into from
Jun 20, 2023

Conversation

hwo-wd
Copy link
Contributor

@hwo-wd hwo-wd commented May 22, 2023 •
edited by guidograzioli
Loading

  • Adds sqlserver JDBC support
  • Improved become: yes handling (tested with JDG only)
Variable Description Default
infinispan_jdbc_engine backend database engine (values: ['mariadb','postgres','sqlserver']) mariadb

@guidograzioli
Copy link
Member

Awesome; sorry to say so, but please split in two PRs: database and systemd (keeping the become change together with either of the two). We use the PR link and description to generate the changelog, that's mostly the reason

@hwo-wd hwo-wd mentioned this pull request May 22, 2023
Merged
@guidograzioli
Copy link
Member

We are hitting the same linter updates as for keycloak; can you please rebase on main?

@hwo-wd
Copy link
Contributor Author

hwo-wd commented May 23, 2023

Rebased.

@guidograzioli guidograzioli added the minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix label May 23, 2023
guidograzioli
guidograzioli requested changes Jun 19, 2023
View reviewed changes
roles/infinispan/tasks/install.yml Outdated Show resolved Hide resolved
hwo-wd added 4 commits June 20, 2023 08:53
@hwo-wd
Infinespan: Add sqlserver JDBC support
85a2a66
@hwo-wd
Infinspan: Various become: yes fixes
a3ad39e
@hwo-wd
JDG: Minor fix for alternate download location
591d349
@hwo-wd
Infinispan: Config: remove obsolete line which causes service start f…
280e0c9 
…ailure

            <!-- <FD_SOCK stack.combine="REMOVE"/> having this line using JDG v8.4.1 leads to `DefaultCacheManager start failed, stopping any running components org.infinispan.commons.CacheConfigurationException` due to `org.infinispan.commons.CacheConfigurationException: ISPN000544: The protocol 'FD_SOCK' does not exist in the base stack for operation 'REMOVE'`-->
@guidograzioli
Copy link
Member

Thank you for the contribution! This is going in now

@guidograzioli guidograzioli merged commit 21bdcf1 into ansible-middleware:main Jun 20, 2023
@guidograzioli guidograzioli changed the title Feature/mssql Add sqlserver to infinispan jdbc configurations Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidograzioli guidograzioli guidograzioli approved these changes

Assignees
No one assigned
Labels
minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwo-wd @guidograzioli