-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure compatibility with python 2.7 / ansible 2.9 #19
Ensure compatibility with python 2.7 / ansible 2.9 #19
Conversation
484faf5
to
f5d411c
Compare
When testing with Python 2.7 and Ansible 2.9, the following warnings are shown:
Using the
To be fair, the error is a bit unrelated to the formatting change noted in this PR and is mostly due to the removal of the If you would be able to look into the warnings, I can take a look at the error as it is a side effect of some of the efforts that I spearheaded |
The above seems to depend on the calling playbook passing |
Can you share your playbook, I am now hitting this: ansible/ansible#72587
|
Latest commit fixes load_file_common_arguments in stable-2.9 reading |
@sabre1041 anything left here? or we can merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix #18
Fix #19 (8682417)