Fix task order for lockout policy #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In windows server 2022, the default values for LockoutDuration and ResetLockoutCount are 30. Setting lockout duration to a value lower than ResetLockoutCount will result in "Failed to import secedit.ini file from C:\\TEMP\\tmpxxxx.tmp" and "The parameter is incorrect" errors. (default applied here is 15) This brings Windows-2022-CIS inline with the order of Windows-2019-CIS which sets ResetLockoutCount first, then LockoutDuration. See this resolved issue: ansible/ansible#62594 Signed-off-by: Shaawing <[email protected]>
|
Thank you @Shaawing ! We have the fix order implemented! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In windows server 2022, the default values for LockoutDuration and ResetLockoutCount are 30.
Setting lockout duration to a value lower than ResetLockoutCount will result in "Failed to import secedit.ini file from C:\TEMP\tmpxxxx.tmp" and "The parameter is incorrect" errors. (default applied here is 15)
This brings Windows-2022-CIS inline with the order of Windows-2019-CIS which sets ResetLockoutCount first, then LockoutDuration.
See this resolved issue: ansible/ansible#62594
Overall Review of Changes
A general description of the changes made that are being requested for merge
Issue Fixes
Please list (using linking) any open issues this PR addresses
Enhancements
Please list any enhancements/features that are not open issue tickets
How has this been tested?
Please give an overview of how these changes were tested. If they were not please use N/A