Fix 2.2.14 evaluate dnsmasq instead of postfix #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected rule 2.2.14 Ensure dnsmasq is not installed (Automated). Signed-off-by: Luca Berton <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
uk-bolly
approved these changes
Jul 6, 2023
|
Great catch, thanks you for taking the time to find the issue and raise the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected rule 2.2.14 Ensure dnsmasq is not installed (Automated) on an RHEL 9 machine without postfix.
Overall Review of Changes:
Fixed 2.2.14 to evaluate dnsmasq instead of postfix.
Issue Fixes:
Previous code evaluate postfix and triggers postfix restart handler when is not needed.
Enhancements:
Running the code on a machine without "postfix" installed didn't end with the "Restart postfix" handler error.
How has this been tested?:
Tested locally on freshly installed RHEL9 with
rhel9cis_dnsmasq_server = falseandrhel9cis_is_mail_server = false.