Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system accounts rule 5.6.2 #43

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

dulin-gnet
Copy link
Contributor

@dulin-gnet dulin-gnet commented Mar 17, 2023

Overall Review of Changes:
Found issue in tasks/section_5/cis_5.6.x.yml

Issue Fixes:
It seems to playbook change all user accounts shell to /usr/sbin/nologin

How has this been tested?:
Yes

Signed-off-by: Marcin Dulinski <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.

@uk-bolly uk-bolly self-requested a review March 17, 2023 15:35
Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb catch

@uk-bolly uk-bolly merged commit 30abc4b into ansible-lockdown:devel Mar 17, 2023
@uk-bolly
Copy link
Member

hi @dulin-gnet

Fantastic spot on this one. Thank you for highlighting this. Your PR is already merged.

Kindest regards

uk-bolly

@dulin-gnet dulin-gnet deleted the fix_system_accounts branch March 17, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants