Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4 : socket vs sockets (typo) #208

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

svennd
Copy link
Contributor

@svennd svennd commented May 22, 2024

Overall Review of Changes:
This looks for all active sockets, but the command is singular

Issue Fixes:

Enhancements:

How has this been tested?:
Manually the command :

[root@ducky svennd]# systemctl list-units --type=sockets
Unknown unit type or load state 'sockets'.
Use -t help to see a list of allowed values.

[root@ducky svennd]# systemctl list-units --type=socket
  UNIT                            LOAD   ACTIVE SUB       DESCRIPTION
  dbus.socket                     loaded active running   D-Bus System Message Bus Socket
  dm-event.socket                 loaded active listening Device-mapper event daemon FIFOs
  lvm2-lvmpolld.socket            loaded active listening LVM2 poll daemon socket
  sssd-kcm.socket                 loaded active listening SSSD Kerberos Cache Manager responder socket
  systemd-coredump.socket         loaded active listening Process Core Dump Socket
  systemd-initctl.socket          loaded active listening initctl Compatibility Named Pipe
  systemd-journald-dev-log.socket loaded active running   Journal Socket (/dev/log)
  systemd-journald.socket         loaded active running   Journal Socket
  systemd-rfkill.socket           loaded active listening Load/Save RF Kill Switch Status /dev/rfkill Watch
  systemd-udevd-control.socket    loaded active running   udev Control Socket
  systemd-udevd-kernel.socket     loaded active running   udev Kernel Socket

LOAD   = Reflects whether the unit definition was properly loaded.
ACTIVE = The high-level unit activation state, i.e. generalization of SUB.
SUB    = The low-level unit activation state, values depend on unit type.
11 loaded units listed. Pass --all to see loaded but inactive units, too.
To show all installed unit files use 'systemctl list-unit-files'.

This looks for all active sockets, but the command is singular

Signed-off-by: Svennd <[email protected]>
Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch
Thank you for this PR

uk-bolly

@uk-bolly uk-bolly merged commit 8adae24 into ansible-lockdown:devel Jun 4, 2024
4 checks passed
@uk-bolly uk-bolly mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants