Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logic, idempotency, auditd, sysctl improvements #18

Merged
merged 105 commits into from
Sep 24, 2022
Merged

logic, idempotency, auditd, sysctl improvements #18

merged 105 commits into from
Sep 24, 2022

Conversation

uk-bolly
Copy link
Member

@uk-bolly uk-bolly commented Jun 20, 2022 •
edited
Loading

Overall Review of Changes:

  • update to auditd template
    • uses facts and template new variable
      • update_audit_template (default false)
  • sysctl template updates and idempotency improvements
  • container discovery usage improvements
  • 3.4.1.5 discovery improvement
  • 5.6.1.4 discovery improvement
  • logrotate process logrotate.timer
  • tidy up become:
  • logic improvements
  • selinux updates
  • rockylinux now supported

How has this been tested?:

Manually

@uk-bolly
removed tfstate files
193fded 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated to use almalinux image
70942f4 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
improved test with idempotency
c0c24ec 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated testing
91da6ff 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
added libselinux requirement
fb1c6e9 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
sysctl control improvements
33ebfea 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
container var usage improvement
b0e038b 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
crypto idempotency
c3c668b 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
auditd, sysctl vars goss version update
d2684c1 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
sysctl improvements, become usage
02c843f 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
container var usage
97a6a61 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
logrotate process update
1dd2b46 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
suditd improvements
b934cbe 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
auditd, sysctl, become tidy up
4336bbf 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updates
6165191 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
added pause for rhel9 aswell
1ab63c7 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
changed to check ssh for all hosts
c02024e 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
fix typo
1836ae1 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated timeout test
a8ec3e3 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
added legacy mount check again
cf6e08c 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Added Managed by Ansible Changes will be lost
b68e8a3 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated handler conditional
c494559 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
added warning count
6b6a4a3 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
added jounald to syslog type
ba791f5 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated with alma vars
df14771 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
removed empty row
de4a7c5 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Add blank row
22326c5 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
1.2.2 rpm gpg key check
28bbc2f 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
tidy up warning message
77a73dd 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
fix logic in warning
e6191de 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Aded comments to each control for auditd
c697431 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
#21 user accts locked during user exec
f45bbd6 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
All passwords are expired during hardening #22
4705e36 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
update
2f8f58d 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updates
90500ce 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Merge branch 'workflow_update' into updates
d7be86e 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated
410074f 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated for rocky an dnow beta
571f2f7 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Added Assertion for passwd set on ansible user
e4bf188 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Added Assertion update
32907dc 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Merge branch 'devel' into updates
bc4b2f3 
rebase
@uk-bolly
lint updates
2974fa5 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
linting
1e22c13 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
lint updates
33340c7 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
lint updates
1992eea 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
lint updates
3df35e0 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
changed audit dir to opt
962319f 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updates
a1d0130 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
lint updates
0d155c4 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
aligned with audit
5c2211f 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
changed default git_branch to devel
d3d819b 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
removed unnecessary when statement
19a8103 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
removed unnecessary become
226f2bc 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
line tidy up
cc2f734 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
removed unnecessary register
cdf8bab 
Signed-off-by: Mark Bolwell <[email protected]>
georgenalen
georgenalen approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@uk-bolly uk-bolly merged commit 5098bee into devel Sep 24, 2022
@uk-bolly uk-bolly deleted the updates branch September 24, 2022 08:43
This was referenced Oct 27, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgenalen georgenalen georgenalen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uk-bolly @georgenalen