Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding requirements.yml #2

Closed

Conversation

andrew-aiken
Copy link

Overall Review of Changes:
Including requirements.yml

Issue Fixes:
Collectiosn requirements file missing #1

Enhancements:
Adding collections requirements.

How has this been tested?:
Tested using packer on amazon linux 2 ecs optimized.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.

Signed-off-by: andrew-aiken <[email protected]>
@andrew-aiken
Copy link
Author

andrew-aiken commented Jul 1, 2022

@georgenalen Input?

@uk-bolly
Copy link
Member

uk-bolly commented Jul 4, 2022

Hi @andrew-aiken

Thank you for taking the time to raise this PR from the issue that i raised. All help and assistance is very much appreciated.
Is it possible you could extend to work with the meta/main.yml also. It would require the following to be added?

collections:
  - community.general
  - community.crypto
  - ansible.posix

Many thanks in advance

uk-bolly

@andrew-aiken
Copy link
Author

Looks like it currently has the collections in meta.

collections:

@uk-bolly uk-bolly mentioned this pull request Aug 5, 2022
@andrew-aiken
Copy link
Author

Added in another PR

@andrew-aiken andrew-aiken deleted the required-modules branch November 16, 2022 15:18
uk-bolly added a commit that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants