Fix bootloader path on EFI images #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the ansible_distribution variable to Amazon instead of CentOS and removed checking bootloader path of other than CentOS systems.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
|
hi @nvntsin Excellent catch on finding the typo. Thank you for taking the time to provide the PR to fix this also. WHile i am happy to accept the change i have noted it is missing the signed-off by as part of the DCO check. If you could please add this, happy to merge this PR asap. many thanks uk-bolly |
uk-bolly
added a commit
that referenced
this pull request
Mar 17, 2023
Signed-off-by: Mark Bolwell <[email protected]>
Merged
Merged
mfortin
pushed a commit
to mfortin/AMAZON2-CIS
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Mark Bolwell <[email protected]> Signed-off-by: fortinm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the ansible_distribution variable to Amazon instead of CentOS and removed checking bootloader path of other than CentOS systems.
Overall Review of Changes:
A general description of the changes made that are being requested for merge
Issue Fixes:
Please list (using linking) any open issues this PR addresses
Enhancements:
Please list any enhancements/features that are not open issue tickets
How has this been tested?:
Please give an overview of how these changes were tested. If they were not please use N/A
Signed-off-by: Navneet Singh [email protected]