Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handlers for CIS 1.1.12 & 1.1.18 #10

Closed
wants to merge 1 commit into from

Conversation

lukebakare
Copy link

When conforming to CIS 1.1.17 (AUDIT | Ensure separate partition exists for /home) and CIS 1.1.11 (AUDIT | Ensure separate partition exists for /var/tmp) the ansible script errors due to the requested handler not being present

1.1.12 | PATCH | Ensure noexec option set on /var/tmp partition
ERROR! The requested handler 'remount var_tmp' was not found in either the main handlers list nor in the listening handlers list

1.1.18 | PATCH | Ensure nodev option set on /home partition
ERROR! The requested handler 'remount home' was not found in either the main handlers list nor in the listening handlers list

Overall Review of Changes:
I have added the handlers to pass this section of the CIS benchmark if partitions have been configured for these directories

How has this been tested?:
Tested on Amazon Linux 2 with partitions created via LVM

When conforming to CIS 1.1.17 (AUDIT | Ensure separate partition exists for /home) and CIS 1.1.11 (AUDIT | Ensure separate partition exists for /var/tmp) the ansible script errors due to the requested handler not being present


1.1.12 | PATCH | Ensure noexec option set on /var/tmp partition
ERROR! The requested handler 'remount var_tmp' was not found in either the main handlers list nor in the listening handlers list

1.1.18 | PATCH | Ensure nodev option set on /home partition
ERROR! The requested handler 'remount home' was not found in either the main handlers list nor in the listening handlers list

I have added the handlers to pass this section of the CIS benchmark if partitions have been configured for these directories
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.

@uk-bolly
Copy link
Member

uk-bolly commented Mar 1, 2023

hi @lukebakare

Thank you for the feedback with regard to amazon2-cis and taking the time to raise the PR. Feedback is always appreciated. While the pipeline is working as expected we have noticed that the DCo portion fails on the test. We do require all commits to be signed-off-by and gpg signed. In this case the sign-off is missing.
If you could git commit --amend and add happy to accept this PR.

many thanks

uk-bolly

@uk-bolly uk-bolly self-requested a review March 2, 2023 11:52
uk-bolly added a commit that referenced this pull request Mar 17, 2023
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly uk-bolly mentioned this pull request Mar 17, 2023
@uk-bolly
Copy link
Member

hi @lukebakare

Thank you again for finding this issue. I have added this PR change into the #14

kind regards

uk-bolly

@uk-bolly uk-bolly closed this Mar 17, 2023
@uk-bolly uk-bolly mentioned this pull request Mar 22, 2023
mfortin pushed a commit to mfortin/AMAZON2-CIS that referenced this pull request Jun 7, 2024
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: fortinm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants