Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy audit binary failed: src is required #18

Closed
swestcott opened this issue Apr 25, 2023 · 1 comment
Closed

Copy audit binary failed: src is required #18

swestcott opened this issue Apr 25, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@swestcott
Copy link

Describe the Issue

I'm running ansible in an environment without internet access so need to copy the goss binary onto the server being hardened rather than download from Github.

Relevant config,

  setup_audit: true
  run_audit: true
  get_goss_file: copy
  copy_goss_from_path: ./goss

Expected Behavior
The local goss binary should be copied to the server being audited

Actual Behavior

TASK [AMAZON2-CIS : copy audit binary] *****************************************
fatal: [default]: FAILED! => {"changed": false, "msg": "src (or content) is required"}

Environment (please complete the following information):

  • Ansible Version: 2.13.7
  • Host Python Version: 3.10.11
  • Ansible Server Python Version: 3.7
  • branch: devel
  • Additional Details:

Additional Notes
Anything additional goes here

Possible Solution

src value is not defined here, https://github.com/ansible-lockdown/AMAZON2-CIS/blob/devel/tasks/LE_audit_setup.yml#L16. I believe it should be set to "{{ copy_goss_from_path }}"

In contrast, the src value is set for Ubuntu albeit with a different variable name, https://github.com/ansible-lockdown/UBUNTU20-CIS/blob/devel/tasks/LE_audit_setup.yml#L16

@swestcott swestcott added the bug Something isn't working label Apr 25, 2023
@swestcott swestcott changed the title Copy audit binary failed: sre is required Copy audit binary failed: src is required Apr 25, 2023
@uk-bolly uk-bolly self-assigned this May 16, 2023
@uk-bolly
Copy link
Member

hi @swestcott

Thank you for taking the time to raise this issue and explain the error. This really helps us to resolve these type of things much faster.
I am adding this into the may23_updates branch for hopeful merge later this week.

Many thanks

uk-bolly

uk-bolly added a commit that referenced this issue May 16, 2023
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly uk-bolly mentioned this issue May 16, 2023
uk-bolly added a commit that referenced this issue May 1, 2024
* #18 corrected

Signed-off-by: Mark Bolwell <[email protected]>

* updated due to #19 great catch

Signed-off-by: Mark Bolwell <[email protected]>

* V2.0.0 final release (#24)

* removed warn: false

Signed-off-by: Mark Bolwell <[email protected]>

* fix typos

Signed-off-by: Mark Bolwell <[email protected]>

* addressed #21

Signed-off-by: Mark Bolwell <[email protected]>

* updated 1.1.2 logic

Signed-off-by: Mark Bolwell <[email protected]>

* updated handler

Signed-off-by: Mark Bolwell <[email protected]>

---------

Signed-off-by: Mark Bolwell <[email protected]>

* Correct 4.1.15 sudo audit syntax (#26)

Signed-off-by: Andrew Davison <[email protected]>

---------

Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Andrew Davison <[email protected]>
Co-authored-by: Andrew Davison <[email protected]>
mfortin pushed a commit to mfortin/AMAZON2-CIS that referenced this issue Jun 7, 2024
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: fortinm <[email protected]>
mfortin pushed a commit to mfortin/AMAZON2-CIS that referenced this issue Jun 7, 2024
* ansible-lockdown#18 corrected

Signed-off-by: Mark Bolwell <[email protected]>

* updated due to ansible-lockdown#19 great catch

Signed-off-by: Mark Bolwell <[email protected]>

* V2.0.0 final release (ansible-lockdown#24)

* removed warn: false

Signed-off-by: Mark Bolwell <[email protected]>

* fix typos

Signed-off-by: Mark Bolwell <[email protected]>

* addressed ansible-lockdown#21

Signed-off-by: Mark Bolwell <[email protected]>

* updated 1.1.2 logic

Signed-off-by: Mark Bolwell <[email protected]>

* updated handler

Signed-off-by: Mark Bolwell <[email protected]>

---------

Signed-off-by: Mark Bolwell <[email protected]>

* Correct 4.1.15 sudo audit syntax (ansible-lockdown#26)

Signed-off-by: Andrew Davison <[email protected]>

---------

Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Andrew Davison <[email protected]>
Co-authored-by: Andrew Davison <[email protected]>
Signed-off-by: fortinm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants