Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

add login option to the driver.py #13

Merged
merged 3 commits into from
Feb 27, 2021

Conversation

Nightreaver
Copy link
Contributor

Without this fix a "molecule login -h XXXX" will fail with

Traceback (most recent call last):
  File "/opt/venv/bin/molecule", line 8, in <module>
    sys.exit(main())
  File "/opt/venv/lib/python3.8/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/opt/venv/lib/python3.8/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/opt/venv/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/venv/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/venv/lib/python3.8/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/opt/venv/lib/python3.8/site-packages/click/decorators.py", line 21, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/opt/venv/lib/python3.8/site-packages/molecule/command/login.py", line 169, in login
    base.execute_subcommand(scenario.config, subcommand)
  File "/opt/venv/lib/python3.8/site-packages/molecule/command/base.py", line 144, in execute_subcommand
    return command(config).execute()
  File "/opt/venv/lib/python3.8/site-packages/molecule/logger.py", line 185, in wrapper
    rt = func(*args, **kwargs)
  File "/opt/venv/lib/python3.8/site-packages/molecule/command/login.py", line 101, in execute
    self._get_login(hostname)
  File "/opt/venv/lib/python3.8/site-packages/molecule/command/login.py", line 144, in _get_login
    login_cmd = self._config.driver.login_cmd_template.format(**login_options)
AttributeError: 'NoneType' object has no attribute 'format'	

Works on my machine ;)

Without this fix a "molecule login -h XXXX" will fail with

```
Traceback (most recent call last):
  File "/opt/venv/bin/molecule", line 8, in <module>
    sys.exit(main())
  File "/opt/venv/lib/python3.8/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/opt/venv/lib/python3.8/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/opt/venv/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/venv/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/venv/lib/python3.8/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/opt/venv/lib/python3.8/site-packages/click/decorators.py", line 21, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/opt/venv/lib/python3.8/site-packages/molecule/command/login.py", line 169, in login
    base.execute_subcommand(scenario.config, subcommand)
  File "/opt/venv/lib/python3.8/site-packages/molecule/command/base.py", line 144, in execute_subcommand
    return command(config).execute()
  File "/opt/venv/lib/python3.8/site-packages/molecule/logger.py", line 185, in wrapper
    rt = func(*args, **kwargs)
  File "/opt/venv/lib/python3.8/site-packages/molecule/command/login.py", line 101, in execute
    self._get_login(hostname)
  File "/opt/venv/lib/python3.8/site-packages/molecule/command/login.py", line 144, in _get_login
    login_cmd = self._config.driver.login_cmd_template.format(**login_options)
AttributeError: 'NoneType' object has no attribute 'format'	
```

Works on my machine ;)
Copy link
Collaborator

@sky-joker sky-joker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Nightreaver for the contribution!
LGTM

@sky-joker sky-joker merged commit dc31605 into ansible-community:master Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants