Skip to content
This repository has been archived by the owner on Jan 8, 2023. It is now read-only.

Require containers.podman collection 1.6.1 or newer #40

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Jun 16, 2021

Adds check for presence of containers.podman collection and requires the latest known version to present. This means that this driver will no longer support podman modules shipped with Ansible 2.9 thus marking that change as major.

Still, installing the collection on 2.9 will make it work but that must be run by the user.

Needed-By: #38

@ssbarnea ssbarnea added major Marks an important and likely breaking change. feature This issue/PR relates to a feature request. labels Jun 16, 2021
@ssbarnea ssbarnea force-pushed the fix/require-collection branch 2 times, most recently from 63b10dc to 99fe693 Compare June 16, 2021 12:35
@ssbarnea ssbarnea requested a review from tadeboro June 16, 2021 12:38
@ssbarnea ssbarnea marked this pull request as ready for review June 16, 2021 12:39
@ssbarnea ssbarnea requested a review from sshnaidm June 16, 2021 12:41
tox.ini Outdated Show resolved Hide resolved
Adds check for presence of containers.podman collection and requires
the latest known version to present. This means that this driver
will no longer work with podman modules shipped with Ansible 2.9.

Still, installing the collection on 2.9 will make it work but that
must be run by the user.
@ssbarnea ssbarnea force-pushed the fix/require-collection branch from 99fe693 to f576ab2 Compare June 16, 2021 13:11
@ssbarnea ssbarnea changed the title Ensure that containers.podman collection is present Require containers.podman collection 1.6.1 or newer Jun 16, 2021
@ssbarnea ssbarnea requested a review from sshnaidm June 16, 2021 13:11
@ssbarnea ssbarnea merged commit 0fcb9da into master Jun 16, 2021
@ssbarnea ssbarnea deleted the fix/require-collection branch June 16, 2021 13:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature This issue/PR relates to a feature request. major Marks an important and likely breaking change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants