Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

[Vote ends on 2022-03-23] Which files to remove from the Ansible 6 installation #76

Closed
felixfontein opened this issue Mar 9, 2022 · 16 comments

Comments

@felixfontein
Copy link
Contributor

felixfontein commented Mar 9, 2022

Summary

From Ansible 6 on, exclude the following directories and files from the installation (and thus from the wheels) for every collection included: tests/, docs/, and every file and directory starting with a period in the collection root ("dot files" like .gitignore, directories like .github/). All files will still be present in the source tarball on PyPi, they will only not be installed and not be present in wheels.

This approach can be amended (after another vote) if it turns out to cause big problems during the alpha/beta phase of Ansible 6. (For Ansible 7 or a later release, we can of course decide to do something else.)

@felixfontein
Copy link
Contributor Author

+1

@markuman
Copy link
Contributor

+1

@briantist
Copy link

+1 either way

but will this also affect ansible-galaxy collection install? imo it should, but maybe that has to be considered separately

@felixfontein
Copy link
Contributor Author

@briantist no, ansible-galaxy collection install is completely unrelated to this and will simply install the complete collection (as it always did before). I also don't think that will change anytime soon.

@Andersson007
Copy link
Contributor

+1

@russoz
Copy link
Contributor

russoz commented Mar 23, 2022

+1

1 similar comment
@konstruktoid
Copy link

+1

@ssbarnea
Copy link
Member

+1 In favor of stripping any files that are not explicitly part of the collection "runtime". Ideally collection archival process should take care of this but we know that the process is not perfect and that too often the archives endup containing more than needed.

@gundalow
Copy link
Contributor

+1

2 similar comments
@dmsimard
Copy link

+1

@jillr
Copy link

jillr commented Mar 23, 2022

+1

@acozine
Copy link
Contributor

acozine commented Mar 23, 2022

+1, slimming down the package is a good idea.

@felixfontein felixfontein removed the active-vote These are currently active votes label Mar 23, 2022
@felixfontein
Copy link
Contributor Author

Votes:

  • +1 from 7 SC members (acozine Andersson007 briantist felixfontein jillr markuman ssbarnea) and 3 community members (dmsimard konstruktoid russoz)
  • no other votes

@jillr
Copy link

jillr commented Mar 23, 2022

Re-count:

  • +1 from 8 SC (gundalow, in addition to Felix's list)
  • +1 from 3 community members
  • no other votes

@felixfontein
Copy link
Contributor Author

Oh, I totally missed gundalow here! Sorry!

@felixfontein felixfontein added the being_implemented This is currently being implemented label Mar 23, 2022
@felixfontein felixfontein moved this from Final Comments to Resolved in Community Topics TODO Mar 23, 2022
felixfontein added a commit to ansible-community/antsibull-build that referenced this issue Mar 23, 2022
* Exclude certain unnecessary files from the bdist.

* Collect ignore list in code (while looking at the real file list), not in template.

* Add changelog fragment.

* Adjust to ansible-community/community-topics#76.
@felixfontein felixfontein removed the being_implemented This is currently being implemented label Mar 23, 2022
@felixfontein
Copy link
Contributor Author

Thanks everyone! ansible-community/antsibull-build#342 is now merged, once a new version of Antsibull is released (end of this week / beginning of next) we're ready for 6.0.0a1 :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests