Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify choices as dictionary instead of list #36

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

felixfontein
Copy link
Collaborator

@briantist
Copy link
Contributor

This looks great, I saw the discussion in IRC and also never knew this was possible. Documenting choices that way is nice.

Only suggestion I have for the output is to have the choice values use C() format. That would be a departure from non-described choices unless we applied it to all of them... which I personally think we should, but I suppose that might need some discussion/voting.

@felixfontein
Copy link
Collaborator Author

@briantist I think that should apply to default as well. I'll do that in a different PR though (since I think that's separate enough), once this one is merged (to avoid conflicts).

@felixfontein felixfontein merged commit 1090321 into ansible-community:main Sep 22, 2022
@felixfontein felixfontein deleted the choices-dict branch September 22, 2022 04:25
@felixfontein
Copy link
Collaborator Author

@briantist @bcoca thanks for your comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants