Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #144

Merged
merged 2 commits into from
May 6, 2023
Merged

Refactor #144

merged 2 commits into from
May 6, 2023

Conversation

felixfontein
Copy link
Collaborator

Contains all changes from #65 that do not change the output.

The idea is that the code changes in #65 get simpler so it's easier to rebase after reformatting the code base. The only other open PR, #75, has almost no code changes, so it can be easily rebased.

@felixfontein felixfontein requested a review from gotmax23 May 6, 2023 18:38
Copy link
Collaborator

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, but please use a more descriptive commit subject than Refactor when squash merging or just push the two commits separately.

@gotmax23
Copy link
Collaborator

gotmax23 commented May 6, 2023

Thanks for working on this!

@felixfontein felixfontein merged commit a58b876 into ansible-community:main May 6, 2023
@felixfontein felixfontein deleted the refactor branch May 6, 2023 19:08
@felixfontein
Copy link
Collaborator Author

@gotmax23 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants