Add tab completion to antsibull-build #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotmax23
approved these changes
Aug 17, 2024
| @@ -0,0 +1,5 @@ | |||
| minor_changes: | |||
| - "If you are using `argcomplete <https://pypi.org/project/argcomplete/>`__, you can now tab-complete ``antsibull-build`` command lines. | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
That doesn't apply since argcomplete wasn't there before.
|
@gotmax23 thanks for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: ansible-community/antsibull-changelog#173
I did work a bit on improving startup times, but that turned out to be more complex since also constants are imported from some packages that are used in the help output, and moving them to
antsibull.constantsturned out not to be trivial (since they are dict keys where the values are functions from that module). Since startup time isn't that bad ("only" ~0.3 seconds) and antsibull-build isn't used by that many folks I've decided to keep the startup as-is.