use tagged releases to pull core porting guides #544
+125
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, except that this should have a changelog fragment (and that urls.py needs a module docstring). I'm kind of glad that I never implemented that the porting guide is extracted from the ansible-core tarball (as the changelog yaml is). That would have made our life a lot more complicated. |
gotmax23
force-pushed
the
porting_guide_tagged
branch
from
b60f03a to
b3203f7
Compare
As of ansible-community/community-topics#240, the location of ansible documentation has changed. This code allows figuring the applicable repo for a certain ansible-core version.
gotmax23
force-pushed
the
porting_guide_tagged
branch
from
b3203f7 to
1569d16
Compare
|
I'd like to reconsider this now that the tagged releases are created automatically in ansible-documentation. |
|
I guess we should revive this then :) |
|
@gotmax23 do you want to continue with this, or should I rebase it and create a new PR? |
|
Feel free to submit a new PR, and I'm happy to review it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: #540
Relates: ansible/ansible-documentation#66