validate-tags: allow ignoring certain collections #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In case you're wondering, I'd like to start validating tags in ansible-build-data CI and perhaps as part of the release process, but first, we need to be able to exclude the collections such as cisco.nso that are up for removal due to not fixing this issue. |
This adds a `-I` / `--ignore` flag to `antsibull-build validate-tags` and `antsibull-build validate-tags-file` to ignore errors for specific collections. `--ignores-file` can be specified separately or simultaneously to ignore collections from a file with a newline separated list of names. Useless ignores are treated as errors by default, but this can be changed with `--no-warn-useless-ignores`. `ignores` and `warn_useless_ignores` arguments were added to `antsibull.tagging.validate_tags()` to support this functionality.
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
|
@felixfontein, PTAL |
felixfontein
approved these changes
Mar 26, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
-I/--ignoreflag toantsibull-build validate-tagsandantsibull-build validate-tags-fileto ignore errors for specific collections.--ignores-filecan be specified separately or simultaneously to ignore collections from a file with a newline separated list of names.Useless ignores are treated as errors by default, but this can be changed with
--no-warn-useless-ignores.ignoresandwarn_useless_ignoresarguments were added toantsibull.tagging.validate_tags()to support this functionality.