setup.py template: Correct Python version classifiers #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'Programming Language :: Python :: 3.8', | ||
| {%- endif %} |
There was a problem hiding this comment.
This is OK as a first fix, but we should really make this depend on python_requires.
There was a problem hiding this comment.
Yeah, this'll work for now but it could be improved. We could get ansible-core's classifiers from the PyPI API and copy the ones that start with Programming Language :: Python :: 3 or something like that. (We could also get rid of they _python key in the deps files and retrieve ansible-core's python_requires from there.)
| 'Programming Language :: Python :: 3.9', | ||
| 'Programming Language :: Python :: 3.10', | ||
| {%- if version.major >= 7 %} | ||
| 'Programming Language :: Python :: 3.11', | ||
| {%- endif %} |
There was a problem hiding this comment.
Maybe we should simply copy the values over from ansible-core? Might be easier than having specialized code which "magically" creates this.
felixfontein
approved these changes
Dec 15, 2022
|
@gotmax23 thanks for fixing this! |
|
Thanks for reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conflicts with #477. I'll rebase that patch to apply the breaking change on top of this PR after this PR is approved.