Bump Python requirement dynamically #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rooftopcellist
approved these changes
Sep 28, 2022
|
Long-term we should find a better mechanism which extracts the minimum Python requirement from ansible-core and stores it in the |
felixfontein
commented
Sep 28, 2022
| @@ -176,7 +176,8 @@ setup( | |||
| {%- if version.major < 5 %} | |||
| python_requires='>=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,!=3.4.*', | |||
| {%- else %} | |||
| python_requires='>=3.8', | |||
| {# Ansible X depends on ansible-core 2.(X+7), which depends on Python 3.(floor((X+11)/2)) - at least for now :) #} | |||
| python_requires='>=3.{{ ((version.major + 11) / 2) | round(0, 'floor') }}', | |||
There was a problem hiding this comment.
Verified manually:
Ansible 5 → 3.8
Ansible 6 → 3.8
Ansible 7 → 3.9
Ansible 8 → 3.9
Ansible 9 → 3.10
Ompragash
approved these changes
Sep 28, 2022
|
@rooftopcellist @Ompragash thanks for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ansible-community/ansible-build-data#154.