Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML validity tests #388

Merged
merged 4 commits into from
Jan 26, 2022
Merged

Conversation

felixfontein
Copy link
Collaborator

Should prevent errors such as the one fixed in #387.

@felixfontein
Copy link
Collaborator Author

Meh. This currently fails because the Sphinx theme generates invalid HTML as well.

@gundalow
Copy link
Contributor

Meh. This currently fails because the Sphinx theme generates invalid HTML as well.

Thanks for adding this test, though isn't that so annoying. Wonder if we can

  1. Ignore Unexpected character in comment found.
  2. Fix the theme
  3. Hack fix the html before running the test.

@felixfontein
Copy link
Collaborator Author

I already created a PR to fix this in the theme: ansible-community/sphinx_ansible_theme#44

@felixfontein
Copy link
Collaborator Author

This actually exposed a real bug: 62a1f52

I've for now switched all docs tests to another sphinx theme (sphinx_rtd_theme), as unfortunately the fix for ansible-sphinx-theme is still not merged.

@felixfontein felixfontein merged commit dedd8cb into ansible-community:main Jan 26, 2022
@felixfontein felixfontein deleted the html-tests branch January 26, 2022 18:46
@felixfontein
Copy link
Collaborator Author

@gundalow @samccann thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants