-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention the plugin type more prominently #364
Conversation
ea83734
to
96a44b2
Compare
@briantist the main reason I added it there is that if you search for |
I see, great explanation @felixfontein ! I think making the plugin type not part of the link would help with what I called "noise" (as someone who is not colorblind) while keeping the other advantages you mentioned (for screen readers etc.). |
See ansible-community/community-topics#57 for a discussion on which of these features we should have and which not. |
fdf0e0f
to
a05485a
Compare
66c07fc
to
4842de7
Compare
ac3a149
to
d9a457f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is looking good!
@briantist @acozine thanks a lot for testing and reviewing! |
Fixes ansible/ansible#75652.
See for example https://ansible.fontein.de/collections/ansible/builtin/index.html#plugin-index: all modules/plugins in the plugin index now have the type next to their name. If you search for 'file', you find both the 'file module' and 'file lookup'.
The pages for these two plugins:
The title now mentiones the type as well, so the search results should be better. The plugin type is already mentioned correctly in the "Note" (I've fixed that recently). In the "See Also" section, the plugin type is also mentioned (https://ansible.fontein.de/collections/ansible/builtin/file_module.html#see-also).
The same is also true for roles (https://ansible.fontein.de/collections/sensu/sensu_go/index.html#role-index, https://ansible.fontein.de/collections/sensu/sensu_go/agent_role.html).