Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base → core #353

Merged
merged 10 commits into from
Dec 11, 2021
Merged

base → core #353

merged 10 commits into from
Dec 11, 2021

Conversation

felixfontein
Copy link
Collaborator

It's time to update the code to stop mentioning ansible-base whereever possible.

This deprecates the --ansible-base-source option to antsibull-docs, and renames it to --ansible-core-source. It also accepts the _ansible_core_version key next to _ansible_base_version for .deps and .build files, and starts writing _ansible_core_version for Ansible 6.

@felixfontein felixfontein requested a review from dmsimard December 7, 2021 21:02
acozine
acozine reviewed Dec 8, 2021
View reviewed changes
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great step forward, leaving ansible- base behind.

I see a couple of things that might be typos and a few places where this PR introduces ansible-base (those are probably on purpose, but I called them out just in case).

src/antsibull/ansible_core.py Outdated Show resolved Hide resolved
src/antsibull/cli/antsibull_docs.py Outdated Show resolved Hide resolved
src/antsibull/tarball.py Show resolved Hide resolved
src/antsibull/cli/antsibull_docs.py Show resolved Hide resolved
tests/units/test_parse_pieces.py Outdated Show resolved Hide resolved
tests/units/test_parse_pieces.py Show resolved Hide resolved
tests/units/test_parse_pieces.py Outdated Show resolved Hide resolved
@felixfontein felixfontein merged commit 5dc66f3 into ansible-community:main Dec 11, 2021
@felixfontein felixfontein deleted the base-core branch December 11, 2021 10:45
@felixfontein
Copy link
Collaborator Author

@acozine thanks for reviewing this!

@felixfontein felixfontein mentioned this pull request Dec 13, 2021
Merged
@felixfontein felixfontein mentioned this pull request May 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acozine acozine acozine left review comments

@dmsimard dmsimard Awaiting requested review from dmsimard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixfontein @acozine