-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move modules to beginning of plugin index #336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! TIL about Jinja macros
{% for name, desc in plugin_maps[plugin_type].items() | sort %} | ||
* :ref:`@{ name }@ <ansible_collections.@{ collection_name }@.@{ name }@_@{ plugin_type }@>` -- @{ desc | rst_ify | indent(width=2) }@ | ||
{% endfor %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this was sort of moved from another place so it's just doing what was already there, but what is the extra spacing for inside {%
on some elements? Does that control indentation somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's basically a visual help for readers. You can see that this is part of another block. (Indenting the {%
itself is not a good idea since that results in extra whitespace in the output.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an alternative to whitespace inside the brackets, it's also possible to use {%-
and -%}
to suppress the extra whitespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tremble true, but the -
quickly eats too much whitespace (like newlines as well).
@briantist @tremble thanks for reviewing! |
And @ariordan-redhat thanks for bringing this up! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
output lgtm!
@samccann thanks for testing this! |
Improved version over #334.
Fixes #331.