Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed when clause to use vault_tls_disable & vault_tls_gossip as bool instead of int comparison #359

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Changed when clause to use vault_tls_disable & vault_tls_gossip as bool instead of int comparison #359

merged 2 commits into from
Dec 12, 2024

Conversation

lakrass
Copy link
Contributor

@lakrass lakrass commented Dec 12, 2024 •
edited
Loading

  • Cast variables to bool (in case someone uses env-vars and enters 0 or 1)
  • Use bool query in when clause instead of integer comparison, so bool values can be assigned to the variables
  • Changed default values of the variables to bool

@lakrass lakrass changed the title Changed when clause to use vault_tls_disable & vault_tls_gossip as bool instead of doing int comparison Changed when clause to use vault_tls_disable & vault_tls_gossip as bool instead of int comparison Dec 12, 2024
@lakrass
Copy link
Contributor Author

lakrass commented Dec 12, 2024

This PR is ready for review!

@FalcoSuessgott
Copy link
Collaborator

LGTM

@FalcoSuessgott FalcoSuessgott merged commit e45fca8 into ansible-community:master Dec 12, 2024
11 checks passed
@lakrass lakrass deleted the fix-squishi-when-clauses branch December 12, 2024 19:42
@lakrass
Copy link
Contributor Author

lakrass commented Dec 12, 2024

Thank you! :)

lakrass added a commit to lakrass/ansible-vault that referenced this pull request Dec 12, 2024
@lakrass
Changed when clause to use vault_tls_disable & vault_tls_gossip as bo…
e95c8a2 
…ol instead of int comparison (ansible-community#359)

* cast vault_tls_disable and vault_tls_gossip to bool instead of doing integer comparison

* changed default values to bools instead of ints

---------

Co-authored-by: lakrass <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lakrass @FalcoSuessgott