Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python 3.8 instead of 3.6 as environment Python version #54

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

felixfontein
Copy link
Contributor

Setup Python 3.6 on ubuntu-latest no longer works since ubuntu-latest == ubuntu-22.04. See actions/setup-python#544.

@webknjaz
Copy link
Member

webknjaz commented Jan 2, 2023

@felixfontein why do you add so many trailing periods to Git commit titles? A typical convention is not to do that, I have never seen this trailing-dot style before.

@webknjaz webknjaz merged commit 9b183cb into ansible-community:main Jan 2, 2023
@felixfontein felixfontein deleted the tests branch January 3, 2023 07:25
@felixfontein
Copy link
Contributor Author

@webknjaz I think commit messages should consist of proper sentences, and these tend to end with periods.

@webknjaz
Copy link
Member

webknjaz commented Jan 3, 2023

@felixfontein looks like you're confusing commit message titles (which is what is displayed if you tell git log to hide most content) with full commit descriptions. Titles shouldn't contain a trailing period (this is one of the things that linters like gitlint check for).

Here's how the Git developers themselves write the commit messages + rationale: https://gist.github.com/webknjaz/cb7d7bf62c3dda4b1342d639d0e78d79.

@felixfontein
Copy link
Contributor Author

@webknjaz I don't think I'm confusing that, I'm mainly having a different opinion.

@webknjaz
Copy link
Member

webknjaz commented Jan 4, 2023

I see. FWIW I've been experimenting with integrating gitlint in some of the other projects I have for a while now and will soon do that across the board because it's important to keep good Git history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants