Add collection-root parameter, add tests for workflow #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
changed the title
|
(Tests are running in felixfontein#1) |
|
The tests are now passing. |
Please, spell "Red Hat" as two separate words, thanks. |
webknjaz
reviewed
Jul 30, 2022
webknjaz
reviewed
Aug 2, 2022
webknjaz
reviewed
Aug 2, 2022
webknjaz
reviewed
Aug 2, 2022
webknjaz
reviewed
Aug 2, 2022
|
@webknjaz thanks for reviewing, extending, and merging this PR. Please note that the matrix is now reduced to one element though (#21 (comment)). |
Yeah, I noticed that post-merge and had to push two more commits on top. This fixes it: 0d03dbf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
collection-rootparameter is necessary for some collection repository layouts seen sometimes with collection repos for Red Hat partners. (See for example https://github.com/F5Networks/f5-ansible.) Also this is necessary to add some basic tests for this repository.