Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubevirt.core to Ansible 10 and 11 #433

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

felixfontein
Copy link
Contributor

Second try, after original PR #419 and revert #432.

Waits for kubevirt/kubevirt.core#110 to be resolved.

@mariolenz
Copy link
Collaborator

It looks like kubevirt/kubevirt.core#110 has been resolved. Should we un-draft and continue?

@felixfontein
Copy link
Contributor Author

I would wait until there is a new release.

@0xFelix
Copy link

0xFelix commented Jul 10, 2024

There is a new release https://github.com/kubevirt/kubevirt.core/releases/tag/1.5.0 :)

@mariolenz
Copy link
Collaborator

@felixfontein Does 1.5.0 look OK to you? If it does, I think you might want to change kubevirt.core: >=1.4.0,<2.0.0 to kubevirt.core: >=1.5.0,<2.0.0 and merge.

@felixfontein felixfontein marked this pull request as ready for review July 10, 2024 16:01
@felixfontein felixfontein requested a review from mariolenz July 10, 2024 16:06
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit 7547222 into ansible-community:main Jul 10, 2024
5 checks passed
@felixfontein
Copy link
Contributor Author

@mariolenz thanks for reviewing!
@0xFelix thanks for pinging about the release!

@felixfontein felixfontein deleted the kubevirt branch July 10, 2024 17:34
@0xFelix
Copy link

0xFelix commented Jul 19, 2024

What would be the appropriate Ansible version to include the next major release of kubevirt.core? Version 2.0.0 is out. :)

@mariolenz
Copy link
Collaborator

Since it's a new major release of the collection, it won't be included in Ansible 10. But it should be included in the next major Ansible release, which will be 11, automatically.

@0xFelix
Copy link

0xFelix commented Jul 23, 2024

@mariolenz Thanks for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants