-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vmware.vmware_rest to Ansible 6 #120
Add vmware.vmware_rest to Ansible 6 #120
Conversation
d5ea5f2
to
3c29516
Compare
@mariolenz i suggest including it in Ansible 5 as we expect more of its minor releases. In this case we need to follow https://github.com/ansible-community/ansible-build-data#the-current-ansible-major-release |
sorry, clicked accidentally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update 6/collection-meta.yaml
. And probably also add it to 5/
.
I thought we wouldn't add
OK now? BTW: I think it would be better if we could get the maintainers automatically from the collections instead of documenting them manually. cc @goneri |
@mariolenz thanks for the PR!
Would be nice! Any ideas on how can we do it? |
@felixfontein thanks for reviewing! |
It would be nice indeed, but I don't see any way to do that. The only place where we have the list of maintainers is in the discussion for the inclusion application. |
I agree, it's not possible at the moment. But how about a new requirement for collections that are part of the community package? Like a mandatory This way, collections could update the list of maintainers themselves. At the moment, they have to inform us somehow or other. If I'm any juge, that's often forgotten so our list of maintainers is probably outdated. For example, I didn't find a single "Update maintainers for collection XYZ" commit. There are a lot of collections included and I can't imagine that there hasn't been any maintainer quitting or joining a collection over the last years. |
Most collections aren't mentioned in the collection-meta.yaml file anyway. We only started adding all new collections there (with the maintainers listed in the inclusion application) after we decided to collect maintainer information in collection-meta.yaml so we'd have some folks to ping in case of problems. But I agree, that information can easily get out of date. If we require a mandatory maintainers file, it should probably be in a machine-readable format to make it possible to automate things (like directly ping the main maintainers in case of general sanity check failures). |
Implements ansible-community/community-topics#99