Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove community.kubernetes from Ansible 6 #116

Merged
merged 2 commits into from
May 2, 2022

Conversation

felixfontein
Copy link
Contributor

No description provided.

Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixfontein thanks for implementing this!

Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixfontein LGTM, thanks for doing this!

There's a comment in ansible.in

community.kubernetes shall be renamed to kubernetes.core, they are already the same build artifact
https://github.com/ansible-collections/community.kubernetes/issues/221"

Should it be removed also it seems to make no sense now?

I'm also OK with keeping it, just wanted to spot

Anyway LGTM

@Andersson007 Andersson007 merged commit 7f27296 into ansible-community:main May 2, 2022
@Andersson007
Copy link
Contributor

@felixfontein thanks for removing!
@mariolenz thanks for reviewing!

@felixfontein felixfontein deleted the remove-kubernetes branch May 2, 2022 11:09
@felixfontein
Copy link
Contributor Author

@mariolenz @Andersson007 thanks for reviewing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants