Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various lookup plugins: Fix docs fields #331

Merged
merged 2 commits into from
May 6, 2022
Merged

Various lookup plugins: Fix docs fields #331

merged 2 commits into from
May 6, 2022

Conversation

mariolenz
Copy link
Collaborator

SUMMARY

I think the author should be Alina Buzachis (@alinabuzachis), not Alina Buzachis <@alinabuzachis>.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

plugins/lookup/cluster_moid.py
plugins/lookup/datacenter_moid.py
plugins/lookup/datastore_moid.py
plugins/lookup/folder_moid.py
plugins/lookup/host_moid.py
plugins/lookup/network_moid.py
plugins/lookup/resource_pool_moid.py
plugins/lookup/vm_moid.py

ADDITIONAL INFORMATION

Documentation fields

@mariolenz mariolenz mentioned this pull request May 6, 2022
Merged
@mariolenz mariolenz changed the title Various lookup plugins: Fix author Various lookup plugins: Fix docs fields May 6, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

❌ ansible-test-cloud-integration-vmware-rest-python38 POST_FAILURE in 17m 42s
✔️ build-ansible-collection SUCCESS in 4m 22s
✔️ ansible-tox-linters SUCCESS in 5m 45s
❌ ansible-test-sanity-docker-devel FAILURE in 8m 22s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 10m 08s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 54s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 05s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 35s
✔️ ansible-galaxy-importer SUCCESS in 4m 19s

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

❌ ansible-test-cloud-integration-vmware-rest-python38 POST_FAILURE in 17m 32s
✔️ build-ansible-collection SUCCESS in 4m 23s
✔️ ansible-tox-linters SUCCESS in 5m 07s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 59s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 14s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 38s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 00s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 13s
✔️ ansible-galaxy-importer SUCCESS in 4m 32s

@mariolenz
Copy link
Collaborator Author

recheck

@mariolenz
Copy link
Collaborator Author

mariolenz commented May 6, 2022 •
edited
Loading

Is it possible that the documentation is wrong? The example looks like this:

DOCUMENTATION = """
  lookup: file
  author: Daniel Hokka Zakrisson <[email protected]>

Developing plugins

But I think the validate-modules wants it to look like this:

DOCUMENTATION = """
  name: file
  author: Daniel Hokka Zakrisson (@GitHubID) <[email protected]>

@alinabuzachis
Copy link
Collaborator

@mariolenz That's one lookup plugin example we have in amazon.aws https://github.com/ansible-collections/amazon.aws/blob/main/plugins/lookup/aws_ssm.py

name: aws_ssm
author:
  - Bill Wang (!UNKNOWN) <ozbillwang(at)gmail.com>

@alinabuzachis
Copy link
Collaborator

alinabuzachis commented May 6, 2022 •
edited
Loading

And this is the PR that solved the listing issues https://github.com/ansible-collections/amazon.aws/pull/701/files

So, I guess this example is wrong.

DOCUMENTATION = """
  lookup: file
  author: Daniel Hokka Zakrisson <[email protected]>

@mariolenz
Copy link
Collaborator Author

Yes, it's name instead of lookup or callback or whatever.

And I think the author needs to be in the form First Last (@GitHubID) <e-mail address>, although the e-mail address seems to be optional. Just like in modules.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

❌ ansible-test-cloud-integration-vmware-rest-python38 POST_FAILURE in 16m 18s
✔️ build-ansible-collection SUCCESS in 6m 41s
✔️ ansible-tox-linters SUCCESS in 5m 05s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 59s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 42s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 05s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 17s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 13s
✔️ ansible-galaxy-importer SUCCESS in 4m 44s

@mariolenz
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

❌ ansible-test-cloud-integration-vmware-rest-python38 POST_FAILURE in 16m 03s
✔️ build-ansible-collection SUCCESS in 4m 26s
✔️ ansible-tox-linters SUCCESS in 5m 09s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 58s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 41s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 40s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 8m 54s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 44s
✔️ ansible-galaxy-importer SUCCESS in 4m 13s

@mariolenz mariolenz closed this May 6, 2022
@mariolenz mariolenz reopened this May 6, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

❌ ansible-test-cloud-integration-vmware-rest-python38 POST_FAILURE in 17m 33s
✔️ build-ansible-collection SUCCESS in 4m 30s
✔️ ansible-tox-linters SUCCESS in 5m 34s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 02s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 33s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 15m 28s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 8m 41s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 21s
✔️ ansible-galaxy-importer SUCCESS in 4m 25s

@mariolenz
Copy link
Collaborator Author

@Akasurde @goneri Any idea why ansible-test-cloud-integration-vmware-rest-python38 keeps running into POST_FAILURE?

This was referenced May 6, 2022
Merged
Merged
@goneri
Copy link
Member

goneri commented May 6, 2022

recheck

@goneri
Copy link
Member

goneri commented May 6, 2022

@Akasurde @goneri Any idea why ansible-test-cloud-integration-vmware-rest-python38 keeps running into POST_FAILURE?

ansible/zuul-config@0d321ce should help 🤞.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-test-cloud-integration-vmware-rest-python38 SUCCESS in 19m 20s
✔️ build-ansible-collection SUCCESS in 5m 26s
✔️ ansible-tox-linters SUCCESS in 5m 36s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 54s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 18s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 13m 52s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 15s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 49s
✔️ ansible-galaxy-importer SUCCESS in 4m 45s

@mariolenz
Copy link
Collaborator Author

Thanks @goneri, ansible/zuul-config#402 helped!

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-test-cloud-integration-vmware-rest-python38 SUCCESS in 16m 09s
✔️ build-ansible-collection SUCCESS in 4m 45s
✔️ ansible-tox-linters SUCCESS in 4m 44s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 18s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 45s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 20m 03s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 8m 58s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 18s
✔️ ansible-galaxy-importer SUCCESS in 4m 38s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit fdcd01c into ansible-collections:main May 6, 2022
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 6, 2022
@goneri
README: add a note about the VM template (#329)
9c16af7 
README: add a note about the VM template

Depends-On: #331

Reviewed-by: Jill R <None>
@mariolenz mariolenz deleted the fix_author branch May 6, 2022 17:32
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 6, 2022
@goneri
tests: remove vcenter_vm_create (#328)
79e0c66 
tests: remove vcenter_vm_create

Depends-On: #331
Superseded by vcenter_vm_customize/
@mariolenz mariolenz mentioned this pull request May 9, 2022
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 9, 2022
@mariolenz
Move Dev Guide to collection (#330)
cf52640 
Move Dev Guide to collection

Depends-On: #331
SUMMARY
Collection-specific docs must move to their collections.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
docsite
ADDITIONAL INFORMATION
see here
cc @samccann

Reviewed-by: Abhijeet Kasurde <None>
Reviewed-by: Sandra McCann <[email protected]>
@mariolenz mariolenz mentioned this pull request May 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariolenz @alinabuzachis @goneri