fix content_template library_id reference in delete #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
- Coverage 27.89% 27.38% -0.52%
==========================================
Files 25 31 +6
Lines 2079 2542 +463
Branches 386 468 +82
==========================================
+ Hits 580 696 +116
- Misses 1499 1846 +347
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mikemorency
requested review from
shellymiron,
elsapassaro,
anna-savina,
prabinovRedhat,
bardielle and
machacekondra
as code owners
mikemorency
force-pushed
the
bugfix/content-template-delete
branch
from
2968421 to
1a58526
Compare
anna-savina
reviewed
Dec 19, 2024
anna-savina
reviewed
Dec 19, 2024
|
lgtm |
prabinovRedhat
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #90
While refactoring the content_template module, one variable reference was missed. There are no tests for the spot that this issue occurred. I fixed the variable and added tests to cover this spot.
ISSUE TYPE
COMPONENT NAME
content_template