Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect update to s3_policy independently of management_policy #8

Merged
merged 1 commit into from
Mar 1, 2022
Merged

detect update to s3_policy independently of management_policy #8

merged 1 commit into from
Mar 1, 2022

Conversation

mmslkr
Copy link

@mmslkr mmslkr commented Dec 23, 2021

SUMMARY

Fixes #7

If both management_policy and s3_policy are managed with na_sg_org_group, modifying either should result in changed = True.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

na_sg_org_group

ADDITIONAL INFORMATION

See #7

@joshedmonds
Copy link
Contributor

Thanks for finding and fixing this! The logic looks correct to me, but will run some tests first before merging.

@joshedmonds joshedmonds merged commit 7e3e76d into ansible-collections:main Mar 1, 2022
@mmslkr mmslkr deleted the group_s3_policy_updated branch March 2, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modifying na_sg_org_group does not update s3_policy when managing management_policy simultaneously
2 participants
@mmslkr @joshedmonds