Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace openshift client with kubernetes client #96

Merged
merged 7 commits into from
May 6, 2021

Conversation

gravesm
Copy link
Member

@gravesm gravesm commented May 5, 2021

SUMMARY

This commit primarily just removes mentions of openshift from the docs
and updates the requirements. Most of the work to replace the client has
been done through the following commits:

edc48ee
c214376
48c5170
2b6a989

Closes #34.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

This commit primarily just removes mentions of openshift from the docs
and updates the requirements. Most of the work to replace the client has
been done through the following commits:

edc48ee
c214376
48c5170
2b6a989
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #96 (19d991a) into main (2b6a989) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   24.02%   24.02%           
=======================================
  Files           1        1           
  Lines         154      154           
  Branches       29       29           
=======================================
  Hits           37       37           
- Misses        111      112    +1     
+ Partials        6        5    -1     
Impacted Files Coverage Δ
...ections/kubernetes/core/plugins/action/k8s_info.py 24.02% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b6a989...19d991a. Read the comment docs.

plugins/lookup/k8s.py Outdated Show resolved Hide resolved
plugins/modules/k8s.py Outdated Show resolved Hide resolved
@gravesm gravesm merged commit 01a0815 into ansible-collections:main May 6, 2021
@gravesm gravesm deleted the remove-openshift branch May 6, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration to kubernetes-client/python Meta-issue
4 participants