Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm_plugin and helm_plugin_info remove unused parameter release_namespace #85

Merged
merged 3 commits into from
May 4, 2021
Merged

helm_plugin and helm_plugin_info remove unused parameter release_namespace #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66bb26a
remove unused parameter release_namespace from documentation
abikouo Apr 27, 2021
a6d9c61
test update
abikouo Apr 27, 2021
693847c
Update changelogs/fragments/85_helm_plugin.yaml
abikouo May 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/fragments/85_helm_plugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
breaking_changes:
- helm_plugin - remove unused ``release_namespace`` parameter.
- helm_plugin_info - remove unused ``release_namespace`` parameter.
2 changes: 0 additions & 2 deletions molecule/default/roles/helm/tasks/tests_helm_diff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
block:
- name: Install helm diff
helm_plugin:
namespace: "{{ helm_namespace }}"
state: present
plugin_path: https://github.com/databus23/helm-diff

Expand Down Expand Up @@ -137,7 +136,6 @@

- name: Uninstall helm diff
helm_plugin:
namespace: "{{ helm_namespace }}"
state: absent
plugin_name: diff
ignore_errors: yes
Expand Down
8 changes: 0 additions & 8 deletions plugins/modules/helm_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,6 @@
description:
- Manages Helm plugins.
options:
# TODO: (akasurde) Remove this in version 2.0
release_namespace:
description:
- Kubernetes namespace where the helm plugin should be installed.
type: str
aliases: [ namespace ]

#Helm options
state:
description:
Expand Down Expand Up @@ -108,7 +101,6 @@ def main():
module = AnsibleModule(
argument_spec=dict(
binary_path=dict(type='path'),
release_namespace=dict(type='str', aliases=['namespace']),
state=dict(type='str', default='present', choices=['present', 'absent']),
plugin_path=dict(type='str',),
plugin_name=dict(type='str',),
Expand Down
8 changes: 0 additions & 8 deletions plugins/modules/helm_plugin_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,6 @@
description:
- Gather information about Helm plugins installed in namespace.
options:
# TODO: (akasurde) Remove this in version 2.0
release_namespace:
description:
- Kubernetes namespace where the helm plugins are installed.
type: str
aliases: [ namespace ]

#Helm options
plugin_name:
description:
Expand Down Expand Up @@ -88,7 +81,6 @@ def main():
module = AnsibleModule(
argument_spec=dict(
binary_path=dict(type='path'),
release_namespace=dict(type='str', aliases=['namespace']),
plugin_name=dict(type='str',),
# Helm options
context=dict(type='str', aliases=['kube_context'], fallback=(env_fallback, ['K8S_AUTH_CONTEXT'])),
Expand Down