Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor(doc): use the same style of version_added across repo #703

Conversation

yurnov
Copy link
Contributor

@yurnov yurnov commented May 6, 2024

SUMMARY

Currently is no single style of version_added, in some places it's unquoted, somewhere single quote is used, in another places it's double quoted. Moreover, some file had different styles in one single file.

The aim of this PR is to update whole repo to single style for version_added

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

kustomize
helm
helm_info
helm_plugin
helm_plugin_info
helm_pull
helm_repository
helm_template
k8s_cluster_info
k8s_cp
k8s_drain
k8s_exec
k8s_log
k8s_rollback
k8s_taint

ADDITIONAL INFORMATION

The same style is proposed as used in amazon.aws collections

Currently is no single style of version_added, somewere it unquoted, somewere in use single quote, somewere double quote, and different style is used even in single file. Aim of that commit it update whole repo to single style for version_added
yurnov added a commit to yurnov/kubernetes.core that referenced this pull request May 6, 2024
Copy link

Copy link

Copy link

@kelvgooding kelvgooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/d68ca32718fd4fefb15559bb67c35bc7

✔️ ansible-galaxy-importer SUCCESS in 4m 26s
✔️ build-ansible-collection SUCCESS in 8m 17s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6360763 into ansible-collections:main May 14, 2024
82 of 88 checks passed
@yurnov
Copy link
Contributor Author

yurnov commented May 14, 2024

@gravesm it worth to backport to both, stable-3 and stable-2.4 to have same doc-style everywhere

Copy link

patchback bot commented May 14, 2024

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/636076309848b6203571deb138f1071341c46861/pr-703

Backported as #715

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 14, 2024
minor(doc): use the same style of version_added across repo

SUMMARY
Currently is no single style of version_added, in some places it's unquoted, somewhere single quote is used, in another places it's double quoted. Moreover, some file had different styles in one single file.
The aim of this PR is to update whole repo to single style for version_added
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
kustomize
helm
helm_info
helm_plugin
helm_plugin_info
helm_pull
helm_repository
helm_template
k8s_cluster_info
k8s_cp
k8s_drain
k8s_exec
k8s_log
k8s_rollback
k8s_taint
ADDITIONAL INFORMATION
The same style is proposed as used in amazon.aws collections

Reviewed-by: Kelv Gooding
Reviewed-by: Alina Buzachis
Reviewed-by: Mike Graves <[email protected]>
(cherry picked from commit 6360763)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 15, 2024
)

[PR #703/63607630 backport][stable-3] minor(doc): use the same style of version_added across repo

This is a backport of PR #703 as merged into main (6360763).
SUMMARY
Currently is no single style of version_added, in some places it's unquoted, somewhere single quote is used, in another places it's double quoted. Moreover, some file had different styles in one single file.
The aim of this PR is to update whole repo to single style for version_added
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
kustomize
helm
helm_info
helm_plugin
helm_plugin_info
helm_pull
helm_repository
helm_template
k8s_cluster_info
k8s_cp
k8s_drain
k8s_exec
k8s_log
k8s_rollback
k8s_taint
ADDITIONAL INFORMATION
The same style is proposed as used in amazon.aws collections

Reviewed-by: Mike Graves <[email protected]>
@yurnov yurnov deleted the version_added_style branch June 17, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants