-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor(doc): use the same style of version_added across repo #703
minor(doc): use the same style of version_added across repo #703
Conversation
Currently is no single style of version_added, somewere it unquoted, somewere in use single quote, somewere double quote, and different style is used even in single file. Aim of that commit it update whole repo to single style for version_added
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 09s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 07s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 26s |
6360763
into
ansible-collections:main
@gravesm it worth to backport to both, |
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #715 🤖 @patchback |
minor(doc): use the same style of version_added across repo SUMMARY Currently is no single style of version_added, in some places it's unquoted, somewhere single quote is used, in another places it's double quoted. Moreover, some file had different styles in one single file. The aim of this PR is to update whole repo to single style for version_added ISSUE TYPE Docs Pull Request COMPONENT NAME kustomize helm helm_info helm_plugin helm_plugin_info helm_pull helm_repository helm_template k8s_cluster_info k8s_cp k8s_drain k8s_exec k8s_log k8s_rollback k8s_taint ADDITIONAL INFORMATION The same style is proposed as used in amazon.aws collections Reviewed-by: Kelv Gooding Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit 6360763)
) [PR #703/63607630 backport][stable-3] minor(doc): use the same style of version_added across repo This is a backport of PR #703 as merged into main (6360763). SUMMARY Currently is no single style of version_added, in some places it's unquoted, somewhere single quote is used, in another places it's double quoted. Moreover, some file had different styles in one single file. The aim of this PR is to update whole repo to single style for version_added ISSUE TYPE Docs Pull Request COMPONENT NAME kustomize helm helm_info helm_plugin helm_plugin_info helm_pull helm_repository helm_template k8s_cluster_info k8s_cp k8s_drain k8s_exec k8s_log k8s_rollback k8s_taint ADDITIONAL INFORMATION The same style is proposed as used in amazon.aws collections Reviewed-by: Mike Graves <[email protected]>
SUMMARY
Currently is no single style of
version_added
, in some places it's unquoted, somewhere single quote is used, in another places it's double quoted. Moreover, some file had different styles in one single file.The aim of this PR is to update whole repo to single style for version_added
ISSUE TYPE
COMPONENT NAME
kustomize
helm
helm_info
helm_plugin
helm_plugin_info
helm_pull
helm_repository
helm_template
k8s_cluster_info
k8s_cp
k8s_drain
k8s_exec
k8s_log
k8s_rollback
k8s_taint
ADDITIONAL INFORMATION
The same style is proposed as used in
amazon.aws
collections