Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s - fix issue with server side apply #549

Merged
merged 9 commits into from
Dec 15, 2022
Merged

k8s - fix issue with server side apply #549

merged 9 commits into from
Dec 15, 2022

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Dec 9, 2022 •
edited
Loading

SUMMARY

Fix #548 and #547

ISSUE TYPE
  • Bugfix Pull Request

@softwarefactory-project-zuul
Copy link

Build failed.

✔️ build-ansible-collection SUCCESS in 3m 14s
❌ ansible-test-sanity-docker-devel FAILURE in 7m 45s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 8m 17s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 9m 50s
❌ ansible-test-sanity-docker-stable-2.11 FAILURE in 10m 22s
❌ ansible-test-sanity-docker-stable-2.12 FAILURE in 8m 14s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 6m 28s
✔️ ansible-test-splitter SUCCESS in 2m 30s
❌ integration-kubernetes.core-devel-1 FAILURE in 41m 00s (non-voting)
✔️ integration-kubernetes.core-devel-2 SUCCESS in 44m 41s (non-voting)
⚠️ integration-kubernetes.core-devel-3 SKIPPED (non-voting)
❌ integration-kubernetes.core-milestone-1 FAILURE in 39m 54s
✔️ integration-kubernetes.core-milestone-2 SUCCESS in 43m 58s
⚠️ integration-kubernetes.core-milestone-3 SKIPPED
❌ integration-kubernetes.core-2.9-1 FAILURE in 40m 57s
❌ integration-kubernetes.core-2.9-2 FAILURE in 44m 58s
⚠️ integration-kubernetes.core-2.9-3 SKIPPED
❌ integration-kubernetes.core-2.10-1 FAILURE in 39m 26s
✔️ integration-kubernetes.core-2.10-2 SUCCESS in 48m 18s
⚠️ integration-kubernetes.core-2.10-3 SKIPPED
❌ integration-kubernetes.core-with-turbo-1 FAILURE in 40m 01s
✔️ integration-kubernetes.core-with-turbo-2 SUCCESS in 45m 14s
⚠️ integration-kubernetes.core-with-turbo-3 SKIPPED
✔️ ansible-tox-linters SUCCESS in 5m 10s
✔️ ansible-test-changelog SUCCESS in 2m 11s
✔️ ansible-galaxy-importer SUCCESS in 4m 15s

@softwarefactory-project-zuul
Copy link

Build failed.

✔️ build-ansible-collection SUCCESS in 3m 22s
❌ ansible-test-sanity-docker-devel FAILURE in 11m 34s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 7m 57s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 44s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 12m 56s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 41s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 6m 01s
✔️ ansible-test-splitter SUCCESS in 2m 43s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 34m 45s (non-voting)
✔️ integration-kubernetes.core-devel-2 SUCCESS in 44m 55s (non-voting)
⚠️ integration-kubernetes.core-devel-3 SKIPPED (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 34m 30s
✔️ integration-kubernetes.core-milestone-2 SUCCESS in 44m 20s
⚠️ integration-kubernetes.core-milestone-3 SKIPPED
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 35m 08s
❌ integration-kubernetes.core-2.9-2 FAILURE in 44m 58s
⚠️ integration-kubernetes.core-2.9-3 SKIPPED
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 35m 17s
✔️ integration-kubernetes.core-2.10-2 SUCCESS in 45m 13s
⚠️ integration-kubernetes.core-2.10-3 SKIPPED
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 34m 35s
✔️ integration-kubernetes.core-with-turbo-2 SUCCESS in 46m 02s
⚠️ integration-kubernetes.core-with-turbo-3 SKIPPED
✔️ ansible-tox-linters SUCCESS in 4m 48s
✔️ ansible-test-changelog SUCCESS in 2m 10s
✔️ ansible-galaxy-importer SUCCESS in 4m 18s

@abikouo
Copy link
Contributor Author

abikouo commented Dec 12, 2022

recheck

@softwarefactory-project-zuul
Copy link

Build failed.

✔️ build-ansible-collection SUCCESS in 3m 16s
❌ ansible-test-sanity-docker-devel FAILURE in 7m 42s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 7m 31s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 01s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 27s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 00s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 6m 15s
✔️ ansible-test-splitter SUCCESS in 2m 34s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 35m 01s (non-voting)
✔️ integration-kubernetes.core-devel-2 SUCCESS in 44m 47s (non-voting)
⚠️ integration-kubernetes.core-devel-3 SKIPPED (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 35m 27s
✔️ integration-kubernetes.core-milestone-2 SUCCESS in 44m 00s
⚠️ integration-kubernetes.core-milestone-3 SKIPPED
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 34m 32s
❌ integration-kubernetes.core-2.9-2 FAILURE in 43m 47s
⚠️ integration-kubernetes.core-2.9-3 SKIPPED
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 34m 26s
✔️ integration-kubernetes.core-2.10-2 SUCCESS in 43m 28s
⚠️ integration-kubernetes.core-2.10-3 SKIPPED
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 34m 35s
✔️ integration-kubernetes.core-with-turbo-2 SUCCESS in 43m 44s
⚠️ integration-kubernetes.core-with-turbo-3 SKIPPED
✔️ ansible-tox-linters SUCCESS in 4m 59s
✔️ ansible-test-changelog SUCCESS in 2m 20s
✔️ ansible-galaxy-importer SUCCESS in 3m 50s

@abikouo abikouo mentioned this pull request Dec 12, 2022
Closed
@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ build-ansible-collection SUCCESS in 3m 11s
❌ ansible-test-sanity-docker-devel FAILURE in 8m 11s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 7m 58s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 06s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 27s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 00s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 6m 36s
✔️ ansible-test-splitter SUCCESS in 2m 32s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 34m 52s (non-voting)
✔️ integration-kubernetes.core-devel-2 SUCCESS in 43m 55s (non-voting)
⚠️ integration-kubernetes.core-devel-3 SKIPPED (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 35m 42s
✔️ integration-kubernetes.core-milestone-2 SUCCESS in 45m 25s
⚠️ integration-kubernetes.core-milestone-3 SKIPPED
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 35m 55s
✔️ integration-kubernetes.core-2.9-2 SUCCESS in 44m 45s
⚠️ integration-kubernetes.core-2.9-3 SKIPPED
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 36m 14s
✔️ integration-kubernetes.core-2.10-2 SUCCESS in 43m 55s
⚠️ integration-kubernetes.core-2.10-3 SKIPPED
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 38m 49s
✔️ integration-kubernetes.core-with-turbo-2 SUCCESS in 46m 37s
⚠️ integration-kubernetes.core-with-turbo-3 SKIPPED
✔️ ansible-tox-linters SUCCESS in 4m 54s
✔️ ansible-test-changelog SUCCESS in 2m 08s
✔️ ansible-galaxy-importer SUCCESS in 4m 21s

@abikouo abikouo mentioned this pull request Dec 13, 2022
Merged
gravesm
gravesm reviewed Dec 14, 2022
View reviewed changes
plugins/module_utils/apply.py Show resolved Hide resolved
plugins/module_utils/apply.py Outdated Show resolved Hide resolved
@abikouo abikouo requested a review from gravesm December 15, 2022 07:24
@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ build-ansible-collection SUCCESS in 3m 18s
❌ ansible-test-sanity-docker-devel FAILURE in 8m 34s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 7m 38s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 37s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 18s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 16s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 5m 37s
✔️ ansible-test-splitter SUCCESS in 2m 27s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 35m 05s (non-voting)
✔️ integration-kubernetes.core-devel-2 SUCCESS in 43m 15s (non-voting)
⚠️ integration-kubernetes.core-devel-3 SKIPPED (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 34m 38s
✔️ integration-kubernetes.core-milestone-2 SUCCESS in 44m 06s
⚠️ integration-kubernetes.core-milestone-3 SKIPPED
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 35m 56s
✔️ integration-kubernetes.core-2.9-2 SUCCESS in 44m 36s
⚠️ integration-kubernetes.core-2.9-3 SKIPPED
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 38m 02s
✔️ integration-kubernetes.core-2.10-2 SUCCESS in 43m 13s
⚠️ integration-kubernetes.core-2.10-3 SKIPPED
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 34m 30s
✔️ integration-kubernetes.core-with-turbo-2 SUCCESS in 44m 41s
⚠️ integration-kubernetes.core-with-turbo-3 SKIPPED
✔️ ansible-tox-linters SUCCESS in 4m 41s
✔️ ansible-test-changelog SUCCESS in 2m 10s
✔️ ansible-galaxy-importer SUCCESS in 3m 57s

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ build-ansible-collection SUCCESS in 3m 11s
❌ ansible-test-sanity-docker-devel FAILURE in 7m 36s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 7m 34s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 24s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 09s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 16s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 6m 19s
✔️ ansible-test-splitter SUCCESS in 2m 25s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 35m 23s (non-voting)
✔️ integration-kubernetes.core-devel-2 SUCCESS in 47m 35s (non-voting)
⚠️ integration-kubernetes.core-devel-3 SKIPPED (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 34m 42s
✔️ integration-kubernetes.core-milestone-2 SUCCESS in 44m 18s
⚠️ integration-kubernetes.core-milestone-3 SKIPPED
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 35m 53s
✔️ integration-kubernetes.core-2.9-2 SUCCESS in 45m 11s
⚠️ integration-kubernetes.core-2.9-3 SKIPPED
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 35m 00s
✔️ integration-kubernetes.core-2.10-2 SUCCESS in 43m 30s
⚠️ integration-kubernetes.core-2.10-3 SKIPPED
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 43m 46s
✔️ integration-kubernetes.core-with-turbo-2 SUCCESS in 48m 10s
⚠️ integration-kubernetes.core-with-turbo-3 SKIPPED
✔️ ansible-tox-linters SUCCESS in 4m 40s
✔️ ansible-test-changelog SUCCESS in 2m 10s
✔️ ansible-galaxy-importer SUCCESS in 3m 49s

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).

✔️ build-ansible-collection SUCCESS in 3m 15s
❌ ansible-test-sanity-docker-devel FAILURE in 8m 56s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 7m 28s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 13s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 26s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 11s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 5m 51s
✔️ ansible-test-splitter SUCCESS in 2m 22s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 35m 22s (non-voting)
✔️ integration-kubernetes.core-devel-2 SUCCESS in 43m 25s (non-voting)
⚠️ integration-kubernetes.core-devel-3 SKIPPED (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 34m 25s
✔️ integration-kubernetes.core-milestone-2 SUCCESS in 43m 16s
⚠️ integration-kubernetes.core-milestone-3 SKIPPED
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 35m 14s
✔️ integration-kubernetes.core-2.9-2 SUCCESS in 43m 59s
⚠️ integration-kubernetes.core-2.9-3 SKIPPED
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 35m 39s
✔️ integration-kubernetes.core-2.10-2 SUCCESS in 43m 33s
⚠️ integration-kubernetes.core-2.10-3 SKIPPED
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 38m 53s
✔️ integration-kubernetes.core-with-turbo-2 SUCCESS in 47m 19s
⚠️ integration-kubernetes.core-with-turbo-3 SKIPPED
✔️ ansible-tox-linters SUCCESS in 5m 07s
✔️ ansible-test-changelog SUCCESS in 2m 16s
✔️ ansible-galaxy-importer SUCCESS in 3m 53s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit c073eea into ansible-collections:main Dec 15, 2022
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Dec 15, 2022
@abikouo
k8s_cp - fix issue when directory contains space in its name (#552)
42ee210 
k8s_cp - fix issue when directory contains space in its name

Depends-On: #549
SUMMARY

There is a remaining issue not addressed by  #512 when copying directory from Pod to local filesystem, if the directory contains space into its name, the directory was not copied

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

k8s_cp
ADDITIONAL INFORMATION

Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Bikouo Aubin <None>
@loganmc10
Copy link

This is a blocking issue for me, is it possible to release a new version with this fix included?

@gravesm gravesm mentioned this pull request Jan 19, 2023
Closed
@stiller-leser
Copy link

Same here, this is blocking for us. Any ETA on a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravesm gravesm gravesm approved these changes

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server side apply broken in kubernetes >= 25.3.0
4 participants
@abikouo @loganmc10 @stiller-leser @gravesm