k8s loop flattening for template argument #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to 49-k8s-loop-flattening-and-continue_on_error.yaml
Codecov Report
@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 23.17% 24.02% +0.84%
==========================================
Files 1 1
Lines 151 154 +3
Branches 24 29 +5
==========================================
+ Hits 35 37 +2
Misses 111 111
- Partials 5 6 +1
Continue to review full report at Codecov.
|
gravesm
requested changes
Apr 12, 2021
changelogs/fragments/49-k8s-loop-flattening-and-continue_on_error.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Graves <[email protected]>
gravesm
reviewed
Apr 12, 2021
gravesm
approved these changes
Apr 13, 2021
abikouo
commented
Apr 16, 2021
|
Thank you for the patch. @abikouo, do you observe a performance improvement with the patch? |
goneri
suggested changes
Apr 19, 2021
goneri
suggested changes
Apr 19, 2021
goneri
suggested changes
Apr 19, 2021
goneri
suggested changes
Apr 19, 2021
gravesm
requested changes
Apr 22, 2021
gravesm
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
k8s loop flattening
https://github.com/ansible-collections/community.kubernetes/pull/369
https://github.com/ansible-collections/community.kubernetes/pull/321
Closes: #19
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
templateargument can now contains list of item (string or file path)continue_on_errorargument is introduced, used with template when multiple resource as defined, defines whether to continue or stop (default behavior) when creation/deletion error occurred.