Add configmap/secret hash functionality #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
add_configmap_secret_hash
branch
from
11c6cbf to
c9bea69
Compare
Codecov Report
@@ Coverage Diff @@
## main #48 +/- ##
=======================================
Coverage 23.17% 23.17%
=======================================
Files 1 1
Lines 151 151
Branches 24 24
=======================================
Hits 35 35
Misses 111 111
Partials 5 5 Continue to review full report at Codecov.
|
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
add_configmap_secret_hash
branch
from
c9bea69 to
7725bf7
Compare
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
add_configmap_secret_hash
branch
from
1815260 to
6dded5e
Compare
|
@geerlingguy @gravesm @fabianvf @goneri Can you please review this? Thanks in advance |
gravesm
approved these changes
Apr 12, 2021
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
fabianvf
approved these changes
Apr 19, 2021
goneri
reviewed
Apr 19, 2021
| @@ -0,0 +1,67 @@ | |||
| # Copyright [2017] [Red Hat, Inc.] | |||
There was a problem hiding this comment.
well the file is new, so it should be 2021.
goneri
reviewed
Apr 19, 2021
| from ansible_collections.kubernetes.core.plugins.module_utils.hashes import generate_hash | ||
|
|
||
| tests = [ | ||
| dict( |
There was a problem hiding this comment.
Just a note, the Ansible community has a weird addiction with the use of dict(), but it's better to use the more Pythonic {"a": "b"} :-).
goneri
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add hash functionality for configmap and secret.
Old PR: ansible-collections/community.kubernetes#404