k8s - add label_selectors options #158
Conversation
Codecov Report
@@ Coverage Diff @@
## main #158 +/- ##
==========================================
- Coverage 24.40% 24.02% -0.38%
==========================================
Files 1 1
Lines 168 154 -14
Branches 32 29 -3
==========================================
- Hits 41 37 -4
+ Misses 120 112 -8
+ Partials 7 5 -2
Continue to review full report at Codecov.
|
…tes.core into k8s_selector_00
There was a problem hiding this comment.
The label_selector on the k8s module should support the same functionality as the label_selector on the k8s_info module, otherwise, it's going to be confusing. Specifically, we need to add support for set-based requirements. See https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#label-selectors.
ok this is not supporting set-based requirement now as there are some filters performed locally, it would be great to have this directly done on kubernetes python client. I will work on it |
|
recheck |
The label_selectors is a new parameter for _wait_for that was introduced in ansible-collections#158. The value is new and it can be set to None to make it optional. It should not be mandatory a non optional parameter.
The label_selectors is a new parameter for _wait_for that was introduced in ansible-collections#158. The value is new and it can be set to None to make it optional. It should not be mandatory a non optional parameter.
The label_selectors is a new parameter for _wait_for that was introduced in ansible-collections#158. The value is new and it can be set to None to make it optional. It should not be mandatory a non optional parameter.
common/_wait_for: ensure label_selectors is optional Depends-On: ansible/ansible-zuul-jobs#1125 The label_selectors is a new parameter for _wait_for that was introduced in #158. The value is new and it can be set to None to make it optional. It should not be mandatory a non optional parameter. Reviewed-by: None <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
…ions#239) common/_wait_for: ensure label_selectors is optional Depends-On: ansible/ansible-zuul-jobs#1125 The label_selectors is a new parameter for _wait_for that was introduced in ansible-collections#158. The value is new and it can be set to None to make it optional. It should not be mandatory a non optional parameter. Reviewed-by: None <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> (cherry picked from commit 938f7e1)
[backport/2.2] common/_wait_for: ensure label_selectors is optional (#239) Depends-On: ansible/ansible-zuul-jobs#1170 Depends-On: ansible/ansible-zuul-jobs#1169 Depends-On: ansible/ansible-zuul-jobs#1171 common/_wait_for: ensure label_selectors is optional The label_selectors is a new parameter for _wait_for that was introduced in #158. The value is new and it can be set to None to make it optional. It should not be mandatory a non optional parameter. Reviewed-by: None Reviewed-by: Alina Buzachis Reviewed-by: None (cherry picked from commit 938f7e1) Reviewed-by: None <None> Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: None <None>
SUMMARY
k8snow supportlabel_selectorsoptions same ask8s_infoResolves #43
ISSUE TYPE
COMPONENT NAME
k8s