-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k8s support diff mode #146
Conversation
Codecov Report
@@ Coverage Diff @@
## main #146 +/- ##
=======================================
Coverage 24.02% 24.02%
=======================================
Files 1 1
Lines 154 154
Branches 29 29
=======================================
Hits 37 37
- Misses 111 112 +1
+ Partials 6 5 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized we also need to fix the k8s_scale
and k8s_json_patch
modules, too.
Co-authored-by: Mike Graves <[email protected]>
This still needs to be addressed. |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
SUMMARY
diff
attribute was always returned in output whenk8s
module was executed using options,force
,apply
orstate=patched
even if thediff=no
was set at task level.This fix aims to correct this
#88
This fix is not working if collection
cloud.common
is used without the fix ansible-collections/cloud.common#65ISSUE TYPE
COMPONENT NAME
k8s