Fix apply on Ansible 2.9 #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the apply function can't be correctly imported in Ansible 2.9. This just renames it to get it to import. I've also added molecule testing on multiple Ansible versions.
abikouo
reviewed
Jun 15, 2021
Codecov Report
@@ Coverage Diff @@
## main #135 +/- ##
=======================================
Coverage 24.02% 24.02%
=======================================
Files 1 1
Lines 154 154
Branches 29 29
=======================================
Hits 37 37
- Misses 111 112 +1
+ Partials 6 5 -1
Continue to review full report at Codecov.
|
abikouo
reviewed
Jun 16, 2021
Akasurde
reviewed
Jun 16, 2021
| @@ -0,0 +1 @@ | |||
| k8s_info.py | |||
There was a problem hiding this comment.
I didn't realize runtime.yml does not work on 2.9. @gravesm Thanks for catching this.
abikouo
approved these changes
Jun 16, 2021
goneri
approved these changes
Jun 16, 2021
alinabuzachis
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
For some reason the apply function can't be correctly imported in
Ansible 2.9. This just renames it to get it to import. I've also added
molecule testing on multiple Ansible versions.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION